-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
doc debian #885
base: main
Are you sure you want to change the base?
doc debian #885
Conversation
Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: gogo.
|
e935cae
to
01b6e6f
Compare
We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added. Sourcegraph teammates: |
I am confused with the chapter 3 of sourcegraph cla. COuld you clarify please? |
@keegancsmith I can not sign the cla. The cla: page not found. |
@jtibshirani did we remove cla-bot, or was that just a dream I had? :) @gogo2464 sorry about the slow response, was on holiday and missed this. Can you motivate why we should be testing specifically on debian on github actions? Is go 1.23.x not available in any debian apt repository yet? FYI once it is, you should be able to use that and go will automatically download the latest patch release/etc as specified in the go.mod. Alternatively we have put off publishing releases, but I believe we should be able to publish static linux binaries (unless I'm forgetting a cgo dep) |
Debian is no more important than any OS. It is just always good to test and to document. Debian needs a specific version that does not work with the current build process. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think running these steps on CI provides much value over our normal linux testing since we generate static binaries. If you want instructions here for others I'd recommend updating the README and linking to an authoritive resource on how to install go 1.23+ on debian.
nice! I will update the readme! |
could be fun to document how to install zoekt on debian with build instruction included.
github action included!