Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc debian #885

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

gogo2464
Copy link

@gogo2464 gogo2464 commented Jan 9, 2025

could be fun to document how to install zoekt on debian with build instruction included.

github action included!

Copy link

cla-bot bot commented Jan 9, 2025

Thank you for your pull request and welcome to our community. We could not parse the GitHub identity of the following contributors: gogo.
This is most likely caused by a git client misconfiguration; please make sure to:

  1. check if your git client is configured with an email to sign commits git config --list | grep email
  2. If not, set it up using git config --global user.email [email protected]
  3. Make sure that the git commit email is configured in your GitHub account settings, see https://github.com/settings/emails

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@gogo2464 gogo2464 force-pushed the document-deploy-debian branch from e935cae to 01b6e6f Compare January 10, 2025 05:59
Copy link

cla-bot bot commented Jan 10, 2025

We require contributors to sign our Contributor License Agreement (CLA), and we don't have yours on file. In order for us to review and merge your code, please sign CLA to get yourself added.

Sourcegraph teammates:

@gogo2464
Copy link
Author

I am confused with the chapter 3 of sourcegraph cla. COuld you clarify please?

@gogo2464
Copy link
Author

@keegancsmith I can not sign the cla. The cla: page not found.

@keegancsmith
Copy link
Member

@jtibshirani did we remove cla-bot, or was that just a dream I had? :)

@gogo2464 sorry about the slow response, was on holiday and missed this. Can you motivate why we should be testing specifically on debian on github actions? Is go 1.23.x not available in any debian apt repository yet? FYI once it is, you should be able to use that and go will automatically download the latest patch release/etc as specified in the go.mod.

Alternatively we have put off publishing releases, but I believe we should be able to publish static linux binaries (unless I'm forgetting a cgo dep)

@gogo2464
Copy link
Author

Debian is no more important than any OS. It is just always good to test and to document. Debian needs a specific version that does not work with the current build process.

Copy link
Member

@keegancsmith keegancsmith left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think running these steps on CI provides much value over our normal linux testing since we generate static binaries. If you want instructions here for others I'd recommend updating the README and linking to an authoritive resource on how to install go 1.23+ on debian.

@gogo2464
Copy link
Author

nice! I will update the readme!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants